Skip to content
This repository has been archived by the owner on Dec 19, 2022. It is now read-only.

Various improvements and fixes #2

Merged
merged 5 commits into from May 14, 2022
Merged

Various improvements and fixes #2

merged 5 commits into from May 14, 2022

Conversation

NikitaIvanovV
Copy link

Hi! I'm the one who asked for dmenu support, thanks for adding it! :)

Some fixes and improvements:

  • ccbd3e2 The original solution checks if a binary file exists in /usr/bin directory, but it's not a reliable way to check if a program is installed because one can have their binary located in any other PATH directory
  • 1be1094 To make dmenu menu look like a list
  • 7b39af7 This unnecessary line creates an empty item in dmenu
  • 650ca05 /usr/bin/env bash is a preferred shebang for bash scripts because it allows bash to be located in places other than /bin
  • 51492c8 /usr/bin is used for binaries installed by system package manager and should not by touched by users, thus /usr/local/bin is a preferred location for manually installed binaries

@ElnuDev ElnuDev merged commit 5a6fde4 into ElnuDev:main May 14, 2022
@ElnuDev
Copy link
Owner

ElnuDev commented May 14, 2022

Thanks so much for the PR! I'm pretty new to bash scripting, this was really helpful. The unnecessary \n was actually creating an empty item in rofi as well, somehow missed that. Really appreciate it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants