This repository has been archived by the owner on Dec 19, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I'm the one who asked for dmenu support, thanks for adding it! :)
Some fixes and improvements:
/usr/bin
directory, but it's not a reliable way to check if a program is installed because one can have their binary located in any other PATH directory/usr/bin/env bash
is a preferred shebang for bash scripts because it allows bash to be located in places other than/bin
/usr/bin
is used for binaries installed by system package manager and should not by touched by users, thus/usr/local/bin
is a preferred location for manually installed binaries