tegakituesday/ji-chan
tegakituesday/ji-chan
1
0
Fork 0
Code Issues Projects Releases Packages Wiki Activity

Improve kanji link validation using HEAD request

Browse source
This commit is contained in:
Elnu 2022-02-15 11:07:12 -08:00
parent c4451c93e2
commit f35bea5489
1 changed files with 4 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
src/commands/kanji.rs
View file

@ -15,28 +15,14 @@ fn random_from_string(string: &str) -> char {
async fn display_kanji(ctx: &Context, msg: &Message, kanji: char, comment: &str) -> CommandResult { async fn display_kanji(ctx: &Context, msg: &Message, kanji: char, comment: &str) -> CommandResult {
msg.reply(&ctx.http, format!("{}{}", kanji, comment)) msg.reply(&ctx.http, format!("{}{}", kanji, comment))
.await?; .await?;
// Not all character codes are covered in mistval/kanji_images.
// The current implementation of 404-checking requires
// the loading of whatever content is hosted on the URL even though
// only the status code (404 for Not Found and 200 for OK) is needed.
//
// This may need to be disabled in production, since it makes
// response times feel sluggish.
//
// Possible ways of fixing this issue:
// - Store the entire mistval/kanji_images dataset locally and check for file presense
// (not desirable, since the remote repository may change)
// - Find a way to make requests but only get the status code
const VALIDATE_LINKS: bool = false;
let url = format!( let url = format!(
"https://raw.githubusercontent.com/mistval/kanji_images/master/gifs/{}.gif", "https://raw.githubusercontent.com/mistval/kanji_images/master/gifs/{}.gif",
format!("{:x}", kanji as i32) format!("{:x}", kanji as i32)
); );
let mut link_validated = true; let client = reqwest::Client::new();
if VALIDATE_LINKS { let request = client.head(&url).build().unwrap();
let response = reqwest::get(&url).await?.text().await?; let response = client.execute(request).await?.status();
link_validated = response != "404: Not Found"; let link_validated = response != reqwest::StatusCode::NOT_FOUND;
}
msg.channel_id msg.channel_id
.say( .say(
&ctx.http, &ctx.http,